processCompositionAudio's per-element loop races each track's async chain
concurrently via Promise.all, which rejects as soon as the first element
fails without waiting for siblings still in flight. A VstChainProcessingError
from one track therefore let another track's VST sidecar subprocess (up to
BOUNCE_TIMEOUT_MS = 10 minutes) keep running after the finally block deleted
workDir out from under it.
Thread an internal AbortController's signal through every element's chain
(extract/prepare/applyVstChainToWav), aborting it in a catch around
Promise.all before workDir is removed, and abort it on the caller's own
external signal too. applyVstChainToWav now accepts { signal } and kills its
spawned sidecar on abort, following runFfmpeg's existing spawn-abort
convention.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
A missing VST plugin or chain file was caught by the per-element try/catch
shared with every soft-degrading failure mode (missing source asset,
download failure, etc): the track was silently dropped and MixResult.success
stayed true, so a render with a missing plugin completed successfully with
no visible error anywhere.
Introduce VstChainProcessingError to mark VST-specific failures and let the
per-element catch rethrow it instead of swallowing it into the warnings
list. The rethrow escapes the Promise.all and rejects
processCompositionAudio itself, which (traced through audioStage.ts's
uncaught await and observability.ts's observeRenderStage, which rethrows)
surfaces as a real render failure through the CLI's existing error-handling
path — the same one every other hard pipeline failure already uses. Every
non-VST failure mode is untouched.
Fixed the two "hard-fails" tests to assert the promise actually rejects
(rejects.toThrow) instead of only checking tracksProcessed/error on an
still-resolved, still-successful result — the previous assertions would
have passed even with the bug present.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Spawns the hyperframes-vst sidecar (packages/vst-host) to bounce a
track's dry WAV through its VST chain before the volume-envelope bake
in processCompositionAudio. A missing plugin or sidecar failure is a
hard failure for that track (named plugin + track id), never a silent
fallback to unprocessed audio.
An unrelated client sending {"cmd":"transport","action":"pause"} could
cancel another connection's active playback task, the same class of bug
the disconnect and play-takeover paths already guard against via
self._play_owner. pause now only cancels/clears the play task when the
sending connection is the current owner; otherwise it is a no-op.
Adds a regression test mirroring the existing disconnect-ownership test.
Track which websocket connection owns the running play task so an
unrelated client disconnecting no longer cancels another client's
active playback. Broaden _dispatch's exception handling so any error
(not just PluginMissingError) — e.g. a KeyError from a command
referencing a not-yet-loaded/unloaded/unknown trackId — replies with
{"event":"error","code":"bad_command"} instead of crashing the
connection with a 1011 close.
Adds two TDD regression tests reproducing both bugs against the
pre-fix code before implementing the fixes.
Adds server.py (VstServer) implementing the full control protocol over one
websocket: load/unload-chain, set-param, get-state, scan, open/close-editor,
and transport (play/pause/seek) with realtime-paced binary PCM streaming via
Task 4's TrackStream/wire-frame codec. Wires up `hyperframes-vst serve
[--port N]` in __main__.py. Adds pytest-asyncio dev dependency and
asyncio_mode = "auto" pytest config for the new async websocket tests.
Moves assetResolution.ts from packages/lint into @hyperframes/parsers behind
a ./asset-resolution subpath export, mirroring the ./ff-binaries shape, and
points lint's two importers at it. Pure move: no behavior change. Unblocks
studio-server consuming the same helpers without a dependency cycle (the CLI
already depends on lint, so importing lint from studio-server is not an option).
The cli, engine, and lint packages each carried their own copy of the
ffmpeg/ffprobe lookup, annotated fallow-ignore code-duplication, and the
copies had drifted: the engine copy handled Windows PATHEXT and executed
which/where without a shell but lacked the Homebrew-dirs fallback for
GUI-spawned processes; the cli copy had the opposite. One resolver in
@hyperframes/parsers (the dependency-graph bottom) now carries the union
of both hardenings, and all three packages delegate to it. Every
consumer gets strictly more robust resolution; env-override semantics
per call site are preserved via configuredMustExist.
A composition variable mirrored as --<slug> for a mounted sub-composition
(default or an explicit data-variable-values value) previously overrode any
same-named custom property the document already authored elsewhere (e.g. a
:root theme token), since the mirroring had no "already defined" guard —
unlike the two other emission paths, which already skip re-emitting when the
name collides with an authored definition. Extend that guard to the
sub-composition mount path in both the compiler (htmlBundler.ts) and the
runtime loader (compositionLoader.ts / getVariables.ts), so an authored
definition always wins; render-time --variables overrides still always win.
* feat(skills): probe and bump stale CLI pins during project resume
The entry skill now keeps a resumed project's pinned CLI current instead of
leaving that to a notice nobody acts on. On resuming a project with pinned
scripts, run the read-only probe 'npx hyperframes@latest upgrade --project
. --check'; when it (or the stale-pin stderr notice, or _meta.updateAvailable
from a pinned run) reports the project behind, apply the bump and verify
with 'hyperframes check'. A failed check reverts the bump and keeps the
project on its pinned version, preserving the reproducibility contract the
pin exists for.
The probe matters because the stale-pin notice only exists in >= 0.7.59:
a pinned run of an older CLI prints no warning at all, so a notice-only
trigger never fires for exactly the projects most behind. The probe runs
unpinned, so its behavior never depends on the project's CLI age.
Telemetry: the fleet converges to new releases within about a week via the
background auto-updater and ephemeral npx, but pinned projects form a
persistent stale tail (~10% of weekly actives, e.g. 6.3k users still on
0.6.x three weeks after 0.7.0).
Both skill surfaces now pass an explicit dir ('--project .') because a bare
'--project' followed by another flag consumes that flag as its directory
value and no-ops; the parsing fix is a separate CLI change.
* fix(cli): stop bare --project from eating the next flag as its directory
citty parses --project as a string option, so 'upgrade --project --check'
arrived with project="--check": the dir resolved to a nonexistent path and
the command no-opd with 'No package.json found' while --check was lost.
The documented default-cwd behavior only worked when --project was the
final token — and the trap-prone form is exactly what the scaffolded
template CLAUDE.md instructs.
A leading dash can never be a real directory argument, so resolveProjectArgs
now reclaims the eaten token as the flag the user wrote (--check / --json),
falls back to the current directory, and drops unrelated eaten flags rather
than treating them as paths. Templates and skill references switch to the
explicit-dir form ('--project .'), which behaves correctly on every release
including ones that predate this fix.
* feat(skills): report a successful pin bump in the run summary
Review follow-up on the stale-pin rule: 'hyperframes check' validates
composition structure, not render-output equivalence, so a check-passing
bump can still shift a project's rendered output. The bump stays the right
default for stale projects, but it must not be silent — the summary now
names the old and new version so the user knows the reproducibility
trade was made.
The committed artifact was generated with an older esbuild than the
current lockfile resolves; CI's check:position-edits-render regen now
produces different (equivalent) minifier variable naming and fails the
diff gate. Regenerate to match — no source change to positionEdits.ts.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
A window.__timelines entry is authored content and may be a partial
RuntimeTimelineLike (duration/seek only, no pause). Timeline resolution
is deliberately permissive — duration-based — and such compositions
render fine, because the render path only seeks. But every interactive
transport path (play/pause/seek, bind, rebind-tick, boot) called
capturedTimeline.pause() unguarded, crashing studio playback with
'tl.pause is not a function' — the top recurring studio:unhandled_error
in telemetry across versions 0.6.121 through 0.7.59 (~150-175/day).
Guard all pause sites through one helper (typeof check + swallow, plus
a once-per-page timeline_missing_pause analytics event so composition
authors can find the partial timeline), matching the safeVoid pattern
player.ts already uses. In the rebind restore path, pause is guarded
separately so a missing pause() no longer aborts the seek/play restore
behind it in the same try/catch.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Both panels showed Layout (X/Y/W/H/Rotation/Z-index) unconditionally —
no gate existed for it at all — and Style was gated only on
canEditStyles (a permission check), never on the element's tag. Neither
gate accounted for `<audio>`, which never paints a visual frame, so a
music track's inspector showed a full set of position/size/fill/shadow
controls with zero visual effect.
Add `layout`/`style` applicability to resolveEditingSections (core),
keyed on tag !== "audio", and gate both panels' Layout section and the
existing Style gate on it. Media/Motion/Grade/Text were already
correctly gated (verified via a research pass across both panels) and
are untouched.
6px between rows left little clearance above a row's value for the
promote-to-variable badge (now positioned above the row). Widen the
row gap to 10px.