* test(release): a release's approver must not have pushed it, and a second maintainer must have
* fix(release): count every pusher of a release, need a second maintainer, date approvals
* docs(release): who may approve a stable release, and the second maintainer it needs
* test(release): a push the activity log records with no account stops the release
* fix(release): a push recorded with no account stops the release
* test(release): npm publishes with the job's OIDC token, no stored token named
* fix(release): publish to npm with the job's OIDC token, not a stored token
* test(release): catch a secret named by index or inherited, not only secrets.X
* test(publish): a stable release counts only maintainers' reviews, never the approver's own push
* fix(publish): a stable release needs a maintainer's approval, not any account's
* fix(publish): only approvers and change requesters are looked up, and a failed lookup always refuses
* style(publish): the release gate's comments and lines fit the 120-character limit
The publish job took the npm dist-tag from the pushed tag's suffix and refused
only an exact "latest". A tag such as v1.2.3-LATEST.1, or one with a new suffix,
still named its own dist-tag. The job's channel check now accepts only alpha,
beta, rc, next, canary, hdr, native and desktop, matched exactly.
* fix(publish): upload only what npm reads as checked, and tag-publish only main commits
npm reads tarballs with node-tar, which can resolve a header differently from the GNU tar
check. A dry run of the same npm now has to agree on name, version and files before anything
is written. A v*-* tag now builds only a commit already on main.
* fix(publish): a v*-* tag publishes a commit on main, next or alpha
Alphas stay cut from next or alpha as release-channels.mdx says; a commit on none of them is
refused before any job builds it, and the error names it as not an ancestor of those branches.
* style(publish): wrap the npm check comment under the 120-column limit
* ci(publish): reuse Lambda assets only from a release this run created (SECOPS-1217)
The pack job downloaded any Lambda handler zip or video image already on the release and pinned it
into @hyperframes/aws-lambda without checking where it came from, so anyone with contents write
could pre-stage both before a stable release.
A new step fails the run when the release exists but github-actions[bot] did not create it during
an earlier attempt of this run, or when a Lambda asset on it was uploaded by anyone else. The pin
steps reuse an asset only when that step allows it.
* fix: bind release retries to immutable run artifacts
* fix: fail release digest pipelines before side effects
The pack job no longer downloads Lambda assets already attached to the
release; it always pins the handler zip and video image this run built.
The publish job decides what the release keeps. Once
@hyperframes/aws-lambda is on npm for the version, the release must hold
exactly the assets that package pins. Before then, an asset this run did
not produce fails a first attempt, and a re-run of the same workflow run
replaces it. An asset identical to the bundle's is left alone, so a
re-run of only the publish job also works.
* ci(publish): publish prebuilt tarballs from a job that runs no release-commit code
Builds, lifecycle scripts and packing move to a pack job with a read-only
token and no secrets. The publish job, which holds the npm token and the
write token, checks each tarball's name and version against the release and
uploads it with lifecycle scripts off. A version already on npm with other
contents fails the first attempt instead of being skipped.
* ci(publish): prerelease tag pushes publish only after a maintainer approves
A prerelease tag can come from any prerelease branch, which no PR review
covers. Tag-push runs now use the npm-prerelease environment, which requires
a maintainer's approval. Merged release PRs keep the npm-publish environment.
* ci(publish): keep every publish in the approval-gated npm-publish environment
npm's trusted publishers are pinned to npm-publish, and that environment now
requires a maintainer's approval with self-review prevented. A second
environment would fail npm auth, so the workflow keeps npm-publish for every
trigger. The docs and test name it as the approval gate.
Builds, lifecycle scripts and packing move to a pack job with a read-only
token and no secrets. The publish job, which holds the npm token and the
write token, checks each tarball's name and version against the release and
uploads it with lifecycle scripts off. A version already on npm with other
contents fails the first attempt instead of being skipped.
## What
- Add `bun run release:prepare <version>` as the maintainer-facing stable release entrypoint.
- Make the first run draft missing changelog artifacts and intentionally exit before tagging; rerunning after manual review delegates to `set-version`.
- Tighten the direct `set-version` guard so stable releases also fail when generated TODO changelog copy is still present.
- Update maintainer docs to recommend `release:prepare` while keeping `changelog:draft` as the lower-level regeneration tool.
## Why
Stable releases should be hard to run without reviewed GitHub release notes and Mintlify changelog copy. This keeps the existing manual rewrite step, but makes the expected path one command that engineers can rerun after review.
## How
- Added `scripts/release-prepare.ts` with parsing, draft/review/set-version action selection, and command forwarding.
- Added focused script tests for parser behavior, action selection, command forwarding, and TODO detection.
- Extracted shared script CLI parsing helpers so `changelog:draft` and `release:prepare` use the same option handling.
- Adjusted `changelog:draft --write` so an existing release file is left unchanged unless `--force` is passed, while still allowing a missing docs entry to be added.
## Test plan
- [x] Unit tests added/updated: `bun run test:scripts`
- [x] Format check: `bun run format:check`
- [x] Lint: `bun run lint`
- [x] Typecheck: `bun run --filter '*' typecheck`
- [x] Fallow audit: `bunx fallow audit --base origin/main --fail-on-issues`
- [x] Manual CLI checks: `bun run release:prepare --help`; `bun run set-version 9.9.9` fails before mutation when changelog artifacts are missing
- [x] Documentation updated
* feat(docs): add changelog release workflow
* fix(scripts): resolve CodeQL findings in release scripts
- draft-changelog.ts: replace existsSync+writeFileSync check-then-act with
an atomic exclusive-write flag (flag: wx) to fix the js/file-system-race
TOCTOU finding; overwrite only under --force (flag: w).
- set-version.ts: switch execSync shell-string git calls to execFileSync with
argument arrays so the interpolated version/paths can never be interpreted
by a shell, resolving the js/indirect-command-line-injection findings.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(scripts): lower writeReleaseNotes complexity below CRAP threshold
The exclusive-write fix pushed writeReleaseNotes to cyclomatic 5 / CRAP 30.0
(fallow/high-crap-score, threshold 30.0). The '!force' guard in the catch is
redundant — EEXIST is only reachable under the 'wx' flag (force=false), since
'w' overwrites without throwing. Dropping it returns the function to cyclomatic
4 / CRAP 20 with identical behavior.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(docs): address changelog review feedback
---------
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>