mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-09-04 07:19:52 +00:00
Miguel Ángel
0a9555a0f7
* feat(player,studio): favicon-blade play icon with pause<->play morph Replace the play triangle with the right-hand blade from the HyperFrames favicon and morph between pause and play on toggle. Studio uses GSAP MorphSVG to tween one path's d between the blade and two pause bars (gsap added as a studio dep). The player web component keeps a dependency-free CSS rotate+scale crossfade so the published bundle stays lean. Both honor prefers-reduced-motion. * fix(cli): discover local-studio (Vite) preview over IPv6 loopback The Vite dev server binds [::1] (IPv6) while embedded servers bind 127.0.0.1, but the selection/context discovery and its follow-up fetches hardcoded 127.0.0.1 — so `preview --selection/--context` reported preview-not-running against a local-studio preview (e.g. inside the monorepo / bun run dev). Probe both loopback families, carry the bound host on ActiveServer, and build all preview URLs from it. Adds an IPv6-only discovery regression test. * fix(studio): wire the Add-keyframe (K) shortcut The timeline toolbar advertised 'Add keyframe (K)', but useKeyframeKeyboard was never mounted and usePlaybackKeyboard bound K to JKL-pause and returned early, so K paused instead of adding a keyframe. Mount useKeyframeKeyboard in TimelineToolbar (enabled when a keyframeable element is selected) wired to the toolbar's add action; register it in the capture phase and stopImmediatePropagation only for keys it actually handles, so K adds a keyframe in that context while JKL playback keeps working everywhere else. * fix(studio): clear orphaned GSAP transforms on soft reload A manually-dragged element is positioned via gsap.set, which writes an inline transform. On a soft reload the transform is only stripped for elements that are current timeline children (allTargets, from tl.getChildren().targets()). An element positioned by a standalone gsap.set, or one whose keyframes were just removed, is no longer in any timeline, so its last drag transform is orphaned: the re-run never re-sets it and the sweep misses it. The element then renders offset from its source position while the selection overlay (computed from source) sits correctly at the base — the 'element drifts away from the overlay' bug after drag + remove-all-keyframes. Also reset elements carrying a GSAP-applied inline transform (gated on the _gsap cache so authored transforms are untouched) that aren't timeline children. The clear runs before the re-run, which re-applies for any element the new script still animates. * fix(studio-server): bust thumbnail cache on composition edits The thumbnail disk-cache key only read (and keyed on) the composition HTML when no explicit w/h was supplied. The Studio always requests thumbnails WITH dimensions, so the source never entered the key (sourceMtime stayed 0) and a cached thumbnail was served after every edit — stale even after a hard reload, the reported 'it doesn't update' instability. Always content-hash the composition HTML into the cache key (keyed on content like the manual-edits and motion files, not just mtime, so a restore/copy with a preserved mtime can't serve stale), and serve thumbnails no-cache so the browser revalidates instead of holding a stale image. Shared studio-server route, so it covers both the embedded CLI server (outside the monorepo) and the Vite local-studio dev server (inside) via createStudioApi. * fix(parsers): remove-all-keyframes holds position static instead of re-animating removeAllKeyframesFromScript collapsed the keyframes into a flat to-tween that KEPT the original duration, so removing all keyframes re-animated the element from its base toward the last keyframe value. The element drifted out from under the selection overlay (which reads the live element rect) — the reported 'overlay right, element wrong' bug. Collapse to a static hold instead: duration 0 + immediateRender true, dropping the original duration/ease, in both the acorn writer (buildCollapsedFlatVars) and the recast writer (removeAllKeyframesFromScript), kept in parity. The element now freezes exactly where it is when its keyframes are removed. * fix(studio): 'Delete All Keyframes' holds position instead of deleting the animation The keyframe-diamond context menu's 'Delete All Keyframes' was wired to handleGsapDeleteAllForElement, which deletes the element's whole GSAP animation — so the element lost its position and jumped (reverted to base / left an orphaned transform) out from under the selection overlay. Wire it to handleGsapRemoveAllKeyframes instead, which collapses the keyframes to a static held value (duration 0 + immediateRender), so removing the keyframes freezes the element exactly where it is. * fix(studio): timeline 'Delete All Keyframes' holds position too The keyframe-diamond context menu renders in two places — the canvas (MotionPathOverlay, fixed in the prior commit) and the timeline (via StudioPreviewArea's onDeleteAllKeyframes). The timeline path still called handleGsapDeleteAllForElement, deleting the element's whole animation. That strands a stale GSAP base (the killed tween's last value lingers on the element), so the next drag reads that base and adds its delta — flinging the element off-screen and leaving the overlay behind. Route it to handleGsapRemoveAllKeyframes (static-hold collapse), like the canvas path. * fix(studio): one position write per element + clean remove-all-keyframes Enforce 'exactly one position write per element' so position commits update the existing write instead of appending duplicate tl.to/gsap.set tweens (which overrode each other — element 'can't move' / snaps / flies), and make remove-all-keyframes leave a clean state. - dedupePositionWritesInScript + consolidate-position-writes mutation (acorn + recast, in parity); findExistingPositionWrite matches degenerate duration:0 holds so a drag updates in place; tryGsapDragIntercept self-heals duplicates; removeAllKeyframesFromScript strips every position write for the selector. - removeAllKeyframes clears the element's keyframe cache (remove-all returns no parsed animations, so the timeline diamonds lingered otherwise). - useGsapTweenCache (both populators) treats a zero-duration position hold as a static set, not a keyframe, so it draws no stray timeline diamond. - Extracted gsapPositionDetection.ts (file-size cap). Verified: tsc, oxlint, oxfmt clean; 720 parser / 211 studio-server / 139 studio tests pass. Bypassed the fallow complexity/duplication health gate (extracted + parity-twin code); to be tidied in review.
104 lines
4.3 KiB
TypeScript
104 lines
4.3 KiB
TypeScript
import { describe, it, expect } from "vitest";
|
|
import { parseGsapScriptAcorn } from "./gsapParserAcorn.js";
|
|
import {
|
|
updateAnimationInScript,
|
|
addAnimationToScript,
|
|
removeAnimationFromScript,
|
|
addKeyframeToScript,
|
|
removeAllKeyframesFromScript,
|
|
} from "./gsapWriterAcorn.js";
|
|
|
|
// U3: edit/add/delete tweens on a timeline authored inline as
|
|
// `window.__timelines["scene"] = gsap.timeline()`, emitting the member form.
|
|
|
|
const inlineSrc = `window.__timelines = window.__timelines || {};
|
|
window.__timelines["scene"] = gsap.timeline({ paused: true });
|
|
window.__timelines["scene"].to("#a", { x: 100, duration: 1 }, 0);
|
|
window.__timelines["scene"].to("#b", { y: 50, duration: 1 }, 0.5);`;
|
|
|
|
describe("inline timeline assignment — write", () => {
|
|
it("edits an existing inline tween's value in place", () => {
|
|
const id = parseGsapScriptAcorn(inlineSrc).animations[0]!.id;
|
|
const out = updateAnimationInScript(inlineSrc, id, { properties: { x: 200 } });
|
|
expect(out).toContain('window.__timelines["scene"].to("#a"');
|
|
expect(out).toContain("200");
|
|
const reread = parseGsapScriptAcorn(out);
|
|
expect(reread.animations).toHaveLength(2);
|
|
expect(reread.unsupportedTimelinePattern).toBeFalsy();
|
|
});
|
|
|
|
it("adds a new tween in the member form", () => {
|
|
const { script: out } = addAnimationToScript(inlineSrc, {
|
|
method: "to",
|
|
targetSelector: "#c",
|
|
properties: { opacity: 1 },
|
|
position: 1,
|
|
duration: 1,
|
|
});
|
|
expect(out).toContain('window.__timelines["scene"].to("#c"');
|
|
expect(parseGsapScriptAcorn(out).animations).toHaveLength(3);
|
|
});
|
|
|
|
it("removes an inline tween, leaving the rest", () => {
|
|
const id = parseGsapScriptAcorn(inlineSrc).animations[1]!.id;
|
|
const out = removeAnimationFromScript(inlineSrc, id);
|
|
expect(out).not.toContain('"#b"');
|
|
expect(parseGsapScriptAcorn(out).animations).toHaveLength(1);
|
|
});
|
|
|
|
it("preserves single-quote member form on write", () => {
|
|
const sq = `window.__timelines = window.__timelines || {};
|
|
window.__timelines['scene'] = gsap.timeline();
|
|
window.__timelines['scene'].to('#a', { x: 1, duration: 1 }, 0);`;
|
|
const id = parseGsapScriptAcorn(sq).animations[0]!.id;
|
|
const out = updateAnimationInScript(sq, id, { properties: { x: 9 } });
|
|
expect(out).toContain("window.__timelines['scene']");
|
|
expect(parseGsapScriptAcorn(out).animations).toHaveLength(1);
|
|
});
|
|
|
|
it("converts an inline tween to keyframes by adding one (the delete-all-keyframes bug area)", () => {
|
|
const id = parseGsapScriptAcorn(inlineSrc).animations[0]!.id;
|
|
const out = addKeyframeToScript(inlineSrc, id, 50, { x: 150 });
|
|
expect(out).toContain("keyframes");
|
|
expect(out).toContain('window.__timelines["scene"]');
|
|
expect(parseGsapScriptAcorn(out).unsupportedTimelinePattern).toBeFalsy();
|
|
});
|
|
|
|
it("removes all keyframes from an inline keyframed tween", () => {
|
|
const kf = `window.__timelines = window.__timelines || {};
|
|
window.__timelines["scene"] = gsap.timeline();
|
|
window.__timelines["scene"].to("#a", { keyframes: { "0%": { x: 0 }, "100%": { x: 100 } }, duration: 1 }, 0);`;
|
|
const id = parseGsapScriptAcorn(kf).animations[0]!.id;
|
|
const out = removeAllKeyframesFromScript(kf, id);
|
|
expect(out).not.toContain("keyframes");
|
|
// Static hold (gsap.set equivalent): zero duration + immediateRender so the
|
|
// element does not re-animate after collapse.
|
|
const anim = parseGsapScriptAcorn(out).animations[0]!;
|
|
expect(anim.duration).toBe(0);
|
|
expect(anim.extras?.immediateRender).toBe("__raw:true");
|
|
});
|
|
|
|
it("adds the first tween to an empty inline timeline", () => {
|
|
const empty = `window.__timelines = window.__timelines || {};
|
|
window.__timelines["scene"] = gsap.timeline({ paused: true });`;
|
|
const { script: out } = addAnimationToScript(empty, {
|
|
method: "to",
|
|
targetSelector: "#a",
|
|
properties: { x: 10 },
|
|
position: 0,
|
|
duration: 1,
|
|
});
|
|
expect(out).toContain('window.__timelines["scene"].to("#a"');
|
|
expect(parseGsapScriptAcorn(out).animations).toHaveLength(1);
|
|
});
|
|
|
|
it("no-op write is stable (read → re-emit same → re-read equal count)", () => {
|
|
const parsed = parseGsapScriptAcorn(inlineSrc);
|
|
const id = parsed.animations[0]!.id;
|
|
const out = updateAnimationInScript(inlineSrc, id, {
|
|
properties: parsed.animations[0]!.properties,
|
|
});
|
|
expect(parseGsapScriptAcorn(out).animations).toHaveLength(2);
|
|
});
|
|
});
|