mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-09-08 10:46:06 +00:00
* fix(render): make WebGL video textures deterministic in headless render WebGL compositions that sample a `<video>` as a texture (e.g. a faceted crystal with clips mapped onto its facets) rendered with flickering, non-deterministic facets: a video would intermittently show a stale frame or go black, and the same frame differed between two renders. Two gaps caused this: 1. No WebGL analog of the WebGPU `patchVideoTextureCompat`. Chrome's headless compositor can't feed decoded `<video>` frames to the GPU, so the engine injects a decoded `<img class="__render_frame__">` sibling per video each frame. The WebGPU `copyExternalImageToTexture` path substitutes it, but `texImage2D` / `texSubImage2D` did not — so WebGL uploaded a stale/black frame. Add `patchWebGLVideoTextureCompat()` mirroring the WebGPU patch (shared `resolveRenderFrameImage` helper). 2. Capture ordering. Per frame the runtime seeks (GPU adapters render on `hf-seek`) BEFORE the engine injects the decoded frames, so the GPU render read a frame that didn't exist yet. After injecting, the engine now calls `window.__hfReseekGpu(t)` — a force-dispatch (`forceDispatchSeekEvent`) that bypasses the same-time `hf-seek` dedup — so GPU compositions re-upload their textures from the freshly-injected, decoded frames, deterministically. Tests: unit tests for the texImage2D/texSubImage2D substitution and the force-dispatch, plus a videoFrameInjector regression test asserting the post-injection GPU reseek fires only when frames were injected. Verified end-to-end: a WebGL prism with 8 live <video> facets renders byte-identical across independent runs with no facet flicker. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test(render): add producer render-compat regression for WebGL video textures A WebGL2 canvas samples a <video> as a texture every hf-seek (the natural author pattern, distilled from the HeyGen prism). The render-compat harness renders it and compares against the golden: with the video-texture fix the render reproduces the decoded frames; revert the fix and the canvas renders black, collapsing the comparison. Golden verified to contain real, time-varying video content (not black), so a regression is caught rather than passing vacuously. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
111 lines
3.7 KiB
TypeScript
111 lines
3.7 KiB
TypeScript
import { describe, it, expect, beforeEach, afterEach } from "vitest";
|
|
import { patchWebGLVideoTextureCompat } from "./video-texture-compat";
|
|
|
|
// Minimal fake WebGL2 context that records the source passed to texImage2D /
|
|
// texSubImage2D, so we can assert the patch substitutes the injected frame.
|
|
class FakeGL2 {
|
|
lastImageArgs: unknown[] | null = null;
|
|
lastSubArgs: unknown[] | null = null;
|
|
texImage2D(...args: unknown[]) {
|
|
this.lastImageArgs = args;
|
|
}
|
|
texSubImage2D(...args: unknown[]) {
|
|
this.lastSubArgs = args;
|
|
}
|
|
}
|
|
|
|
function makeInjectedImage(): HTMLImageElement {
|
|
const img = document.createElement("img");
|
|
img.classList.add("__render_frame__");
|
|
Object.defineProperty(img, "complete", { value: true, configurable: true });
|
|
Object.defineProperty(img, "naturalWidth", { value: 16, configurable: true });
|
|
return img;
|
|
}
|
|
|
|
describe("patchWebGLVideoTextureCompat", () => {
|
|
let originalGL2: unknown;
|
|
|
|
beforeEach(() => {
|
|
originalGL2 = (globalThis as Record<string, unknown>).WebGL2RenderingContext;
|
|
(globalThis as Record<string, unknown>).WebGL2RenderingContext = FakeGL2;
|
|
document.body.innerHTML = "";
|
|
});
|
|
|
|
afterEach(() => {
|
|
(globalThis as Record<string, unknown>).WebGL2RenderingContext = originalGL2;
|
|
document.body.innerHTML = "";
|
|
});
|
|
|
|
it("substitutes the decoded __render_frame__ image when uploading a <video>", () => {
|
|
patchWebGLVideoTextureCompat();
|
|
|
|
const video = document.createElement("video");
|
|
const img = makeInjectedImage();
|
|
document.body.append(video, img); // img is video.nextElementSibling
|
|
|
|
const gl = new FakeGL2();
|
|
gl.texImage2D(0x0de1, 0, 0x1908, 0x1908, 0x1401, video);
|
|
|
|
// Last argument (the source) must be swapped to the injected image.
|
|
expect(gl.lastImageArgs?.[gl.lastImageArgs.length - 1]).toBe(img);
|
|
});
|
|
|
|
it("leaves the <video> source untouched when no render frame is present (preview)", () => {
|
|
patchWebGLVideoTextureCompat();
|
|
|
|
const video = document.createElement("video");
|
|
document.body.append(video);
|
|
|
|
const gl = new FakeGL2();
|
|
gl.texImage2D(0x0de1, 0, 0x1908, 0x1908, 0x1401, video);
|
|
|
|
expect(gl.lastImageArgs?.[gl.lastImageArgs.length - 1]).toBe(video);
|
|
});
|
|
|
|
it("ignores a render-frame image that is not yet decoded", () => {
|
|
patchWebGLVideoTextureCompat();
|
|
|
|
const video = document.createElement("video");
|
|
const img = document.createElement("img");
|
|
img.classList.add("__render_frame__");
|
|
Object.defineProperty(img, "complete", { value: false, configurable: true });
|
|
Object.defineProperty(img, "naturalWidth", { value: 0, configurable: true });
|
|
document.body.append(video, img);
|
|
|
|
const gl = new FakeGL2();
|
|
gl.texImage2D(0x0de1, 0, 0x1908, 0x1908, 0x1401, video);
|
|
|
|
expect(gl.lastImageArgs?.[gl.lastImageArgs.length - 1]).toBe(video);
|
|
});
|
|
|
|
it("also patches texSubImage2D", () => {
|
|
patchWebGLVideoTextureCompat();
|
|
|
|
const video = document.createElement("video");
|
|
const img = makeInjectedImage();
|
|
document.body.append(video, img);
|
|
|
|
const gl = new FakeGL2();
|
|
gl.texSubImage2D(0x0de1, 0, 0, 0, 0x1908, 0x1401, video);
|
|
|
|
expect(gl.lastSubArgs?.[gl.lastSubArgs.length - 1]).toBe(img);
|
|
});
|
|
|
|
it("does not touch numeric/pixel-data overloads (no video source)", () => {
|
|
patchWebGLVideoTextureCompat();
|
|
|
|
const pixels = new Uint8Array([1, 2, 3, 4]);
|
|
const gl = new FakeGL2();
|
|
gl.texImage2D(0x0de1, 0, 0x1908, 1, 1, 0, 0x1908, 0x1401, pixels);
|
|
|
|
expect(gl.lastImageArgs?.[gl.lastImageArgs.length - 1]).toBe(pixels);
|
|
});
|
|
|
|
it("is idempotent — patching twice does not double-wrap", () => {
|
|
patchWebGLVideoTextureCompat();
|
|
const once = FakeGL2.prototype.texImage2D;
|
|
patchWebGLVideoTextureCompat();
|
|
expect(FakeGL2.prototype.texImage2D).toBe(once);
|
|
});
|
|
});
|