Files
hyperframes/packages/aws-lambda/scripts/runtimeLock.ts
T
James RussoandClaude Opus 5.5 f9255e39a5 fix(aws-lambda): the handler ZIP installs its runtime from a committed lockfile with scripts off (#7485)
* fix(aws-lambda): the handler ZIP installs its runtime from a committed lockfile with scripts off

build-zip.ts ran `npm install --no-package-lock` in the publish job, so
transitive versions floated at release time and any dependency's install
script ran beside the release credentials. The ZIP now runs `npm ci
--ignore-scripts` from runtime-lock/<source>/package-lock.json (versions
and integrity for every package), and the build fails if that lock
disagrees with bun.lock instead of falling back to a range or "latest".
`bun packages/aws-lambda/scripts/lock-runtime.ts` regenerates it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(aws-lambda): check only direct runtime versions against bun.lock; Renovate refreshes the rest

The runtime lock's transitive tree is npm's own resolution, not bun.lock's (modern-tar
0.8.6 there vs 0.8.4 in bun.lock), so the parity claim now covers puppeteer-core and
@sparticuz/chromium only. Renovate's weekly lockFileMaintenance refreshes the transitive
tree; its direct-version bumps are off for these dirs because those follow bun.lock.

— Rames Jusso

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(aws-lambda): keep the maintainer-only lock-runtime script out of the package

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-10 10:41:20 +00:00

54 lines
2.5 KiB
TypeScript

import { existsSync, readFileSync } from "node:fs";
import { dirname, join, resolve } from "node:path";
import { fileURLToPath } from "node:url";
export type RuntimeSource = "sparticuz" | "chrome-headless-shell";
const scriptDir = dirname(fileURLToPath(import.meta.url));
export const RUNTIME_LOCK_DIR = join(scriptDir, "runtime-lock");
export const BUN_LOCK_PATH = resolve(scriptDir, "../../../bun.lock");
export const RUNTIME_SOURCES: RuntimeSource[] = ["sparticuz", "chrome-headless-shell"];
export function runtimePackages(source: RuntimeSource): string[] {
return source === "sparticuz" ? ["puppeteer-core", "@sparticuz/chromium"] : ["puppeteer-core"];
}
/** The version bun.lock resolved for a package, or null when it has no entry. */
export function bunLockVersion(lockText: string, moduleName: string): string | null {
const name = moduleName.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
return new RegExp(`"${name}":\\s*\\["${name}@([^"]+)"`).exec(lockText)?.[1] ?? null;
}
/**
* Where the committed lock's direct versions (puppeteer-core, @sparticuz/chromium) disagree with
* bun.lock; empty when they match. The transitive tree is the lock's own: npm resolves it, and
* Renovate's lockFileMaintenance refreshes it (see .github/renovate.json), so it can differ from bun.lock.
*/
export function lockMismatches(source: RuntimeSource, bunLockText: string): string[] {
const lockPath = join(RUNTIME_LOCK_DIR, source, "package-lock.json");
if (!existsSync(lockPath)) return [`${source}: no committed package-lock.json`];
const lock = JSON.parse(readFileSync(lockPath, "utf-8")) as {
packages: Record<string, { version?: string }>;
};
return runtimePackages(source).flatMap((name) => {
const want = bunLockVersion(bunLockText, name);
const locked = lock.packages[`node_modules/${name}`]?.version;
if (!want) return [`${source}: bun.lock has no entry for ${name}`];
return locked === want
? []
: [`${source}: ${name} is ${locked ?? "missing"}, bun.lock has ${want}`];
});
}
/** In the repo, refuses a runtime lock that no longer matches bun.lock; a published package has no bun.lock to compare. */
export function assertRuntimeLockCurrent(source: RuntimeSource): void {
if (!existsSync(BUN_LOCK_PATH)) return;
const stale = lockMismatches(source, readFileSync(BUN_LOCK_PATH, "utf-8"));
if (stale.length > 0) {
throw new Error(
`[build-zip] runtime lock is stale (${stale.join("; ")}). ` +
`Run 'bun packages/aws-lambda/scripts/lock-runtime.ts'.`,
);
}
}