mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-09-05 10:14:30 +00:00
Miguel Ángel
3388635f1d
The audio engine shells out to `python3` for ElevenLabs TTS
(tts.mjs) and the local Lyria/MusicGen BGM paths (bgm.mjs). `python3`
is correct on macOS/Linux, but a standard python.org install on
Windows only creates `python.exe` plus the `py` launcher -- there is
no `python3.exe` (only the Microsoft Store build adds one). So every
`spawn("python3", ...)`/`spawnSync("python3", ...)` ENOENTs on a normal
Windows Python setup, silently disabling all Python-backed audio
features until the user hand-creates a `python3.exe` shim (reported: a
user copied python.exe to python3.exe to work around it, and separately
another had to target a python3 stub specifically).
Fix: a shared lib/python.mjs resolver probes the platform's candidates
in order and returns the argv prefix that actually launches Python 3 --
`["python3"]` / `["python"]` / `["py", "-3"]` on win32, `["python3"]`
then `["python"]` elsewhere -- resolved once per process. All direct
`python3` spawn sites in tts.mjs (elevenlabs probe + synth) and bgm.mjs
(pyOk probe, Lyria recipe, MusicGen script) now route through it. On
macOS/Linux `python3` still wins first, so behavior there is unchanged;
if nothing probes OK the resolver falls back to `python3` so the spawn
fails loudly exactly as before, never worse.
Scope: only the direct python3 invocations. bgm.mjs's pipInstall()
still shells `pip` -- switching that to `<python> -m pip` is the
separate concern of the open PR #1894 (draft); noting the overlap so
the two don't collide. Windows-specific whisper.cpp-vs-openai-whisper
detection and the npm_execpath/npx spawn issue from the same report are
distinct root causes, not addressed here.
Test: python.test.mjs (node:test) covers every platform/probe branch
with an injected probe -- no real interpreter spawned: non-win32 picks
python3; win32 prefers python3, falls back to python, then to `py -3`;
the py launcher is probed as `py -3 --version`; nothing-runs falls back
to the canonical python3; and pythonInvocation keeps the launcher's -3
ahead of caller args. Existing tts.spawn.test.mjs still passes (6/6).
69 lines
2.6 KiB
JavaScript
69 lines
2.6 KiB
JavaScript
import { test } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import { resolvePythonCommand, pythonInvocation } from "./python.mjs";
|
|
|
|
// Regression: on Windows a standard python.org install has no `python3.exe`
|
|
// (only `python.exe` + the `py` launcher), so `spawn("python3", …)` ENOENTs and
|
|
// every Python-backed audio feature silently no-ops. resolvePythonCommand takes
|
|
// injectable platform/probe params so all branches are testable without
|
|
// spawning a real interpreter.
|
|
|
|
// probeFor(names): a probe that reports success only for the given argv-0 names.
|
|
function probeFor(...names) {
|
|
const ok = new Set(names);
|
|
return (cmd) => ok.has(cmd);
|
|
}
|
|
|
|
test("non-win32 uses python3 when it runs", () => {
|
|
assert.deepEqual(resolvePythonCommand("linux", probeFor("python3")), ["python3"]);
|
|
assert.deepEqual(resolvePythonCommand("darwin", probeFor("python3")), ["python3"]);
|
|
});
|
|
|
|
test("win32 prefers python3 when the Microsoft Store build provides it", () => {
|
|
assert.deepEqual(resolvePythonCommand("win32", probeFor("python3", "python", "py")), ["python3"]);
|
|
});
|
|
|
|
test("win32 falls back to python.exe when python3 is absent (python.org install)", () => {
|
|
// The exact reported scenario: no python3, but `python` exists.
|
|
assert.deepEqual(resolvePythonCommand("win32", probeFor("python", "py")), ["python"]);
|
|
});
|
|
|
|
test("win32 falls back to the py launcher with -3 when only py exists", () => {
|
|
assert.deepEqual(resolvePythonCommand("win32", probeFor("py")), ["py", "-3"]);
|
|
});
|
|
|
|
test("py launcher is probed as `py -3 --version`, not bare `py`", () => {
|
|
const seen = [];
|
|
const probe = (cmd, args) => {
|
|
seen.push([cmd, ...args]);
|
|
return cmd === "py";
|
|
};
|
|
resolvePythonCommand("win32", probe);
|
|
assert.deepEqual(seen.at(-1), ["py", "-3", "--version"]);
|
|
});
|
|
|
|
test("falls back to the canonical name (loud failure, unchanged) when nothing runs", () => {
|
|
// No interpreter anywhere — must not throw, and must return python3 so the
|
|
// eventual spawn fails exactly as it did before this fix, never worse.
|
|
assert.deepEqual(
|
|
resolvePythonCommand("win32", () => false),
|
|
["python3"],
|
|
);
|
|
assert.deepEqual(
|
|
resolvePythonCommand("linux", () => false),
|
|
["python3"],
|
|
);
|
|
});
|
|
|
|
test("pythonInvocation prepends the resolved prefix ahead of caller args", () => {
|
|
assert.deepEqual(pythonInvocation(["-c", "import x"], ["python"]), {
|
|
cmd: "python",
|
|
args: ["-c", "import x"],
|
|
});
|
|
// The py launcher's -3 must stay ahead of the caller's own arguments.
|
|
assert.deepEqual(pythonInvocation(["-c", "import x"], ["py", "-3"]), {
|
|
cmd: "py",
|
|
args: ["-3", "-c", "import x"],
|
|
});
|
|
});
|