Files
hyperframes/packages/producer/tests/style-11-prod/src/code_review.md
T
Vance Ingalls 20be2ea1c2 style: apply oxfmt baseline formatting across all source files (#25)
## Summary
- Run `oxfmt .` across the entire codebase to establish formatted baseline
- 299 files changed — mechanical formatting only, no logic changes
- Double quotes, semicolons, 2-space indent, trailing commas, 100 print width

Part 3/4 of [VA-851](https://linear.app/heygen/issue/VA-851/pre-migration-configure-eslint-prettier-and-conventional-commits)

## Test plan
- [x] `pnpm format:check` — all 426 files pass
- [x] `pnpm -r typecheck` — all packages pass
- [x] `pnpm build` — all packages build
- [x] All 348 tests pass
2026-03-23 17:15:14 -07:00

1.9 KiB

HyperFrame Schema Compliance Review

Executive Summary

  • Total files reviewed: 4
  • Critical issues: 0
  • Overall compliance status: PASS

Critical Issues

None. The compositions follow the HyperFrame schema correctly, including deterministic logic, finite timelines, and proper registration.

Compliance Checklist

  • All compositions have data-width and data-height attributes
  • All timelines are finite with duration > 0
  • All compositions registered in window.__timelines
  • No use of Math.random(), Date.now(), or non-deterministic code
  • Primitive clips have required data attributes (id, data-start, data-track)
  • data-duration specified for all <img> clips (N/A - no <img> clips used)
  • No manual media playback control (video.play(), audio.pause(), etc.)
  • No manual clip mounting/unmounting in scripts
  • Relative timing references are valid (N/A - absolute timing used)
  • Clips on same track don't overlap in time
  • Reusable compositions in separate HTML files
  • Composition files use <template> tags
  • External compositions loaded via data-composition-src
  • All script-animated content wrapped in compositions
  • No infinite or zero-duration timelines

[index.html]

Status: COMPLIANT

Issues Found:

  • None. The root composition correctly orchestrates sub-compositions and the A-roll video.

[compositions/bg-grid.html]

Status: COMPLIANT

Issues Found:

  • None. The script uses deterministic loops and fixed arrays for cube placement. The timeline is registered correctly.

[compositions/mg-overlays.html]

Status: COMPLIANT

Issues Found:

  • None. The script uses a finite loop for the background grid pulse instead of an infinite repeat, ensuring a finite timeline.

[compositions/captions.html]

Status: COMPLIANT

Issues Found:

  • None. Captions are grouped and animated deterministically based on the transcript.