mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-09-07 18:26:17 +00:00
Vance Ingalls
20be2ea1c2
## Summary - Run `oxfmt .` across the entire codebase to establish formatted baseline - 299 files changed — mechanical formatting only, no logic changes - Double quotes, semicolons, 2-space indent, trailing commas, 100 print width Part 3/4 of [VA-851](https://linear.app/heygen/issue/VA-851/pre-migration-configure-eslint-prettier-and-conventional-commits) ## Test plan - [x] `pnpm format:check` — all 426 files pass - [x] `pnpm -r typecheck` — all packages pass - [x] `pnpm build` — all packages build - [x] All 348 tests pass
62 lines
1.9 KiB
Markdown
62 lines
1.9 KiB
Markdown
# HyperFrame Schema Compliance Review
|
|
|
|
## Executive Summary
|
|
|
|
- Total files reviewed: 4
|
|
- Critical issues: 0
|
|
- Overall compliance status: PASS
|
|
|
|
## Critical Issues
|
|
|
|
None. The compositions follow the HyperFrame schema correctly, including deterministic logic, finite timelines, and proper registration.
|
|
|
|
## Compliance Checklist
|
|
|
|
- [x] All compositions have `data-width` and `data-height` attributes
|
|
- [x] All timelines are finite with duration > 0
|
|
- [x] All compositions registered in `window.__timelines`
|
|
- [x] No use of `Math.random()`, `Date.now()`, or non-deterministic code
|
|
- [x] Primitive clips have required data attributes (`id`, `data-start`, `data-track`)
|
|
- [x] `data-duration` specified for all `<img>` clips (N/A - no `<img>` clips used)
|
|
- [x] No manual media playback control (`video.play()`, `audio.pause()`, etc.)
|
|
- [x] No manual clip mounting/unmounting in scripts
|
|
- [x] Relative timing references are valid (N/A - absolute timing used)
|
|
- [x] Clips on same track don't overlap in time
|
|
- [x] Reusable compositions in separate HTML files
|
|
- [x] Composition files use `<template>` tags
|
|
- [x] External compositions loaded via `data-composition-src`
|
|
- [x] All script-animated content wrapped in compositions
|
|
- [x] No infinite or zero-duration timelines
|
|
|
|
### [index.html]
|
|
|
|
**Status**: COMPLIANT
|
|
|
|
**Issues Found**:
|
|
|
|
- None. The root composition correctly orchestrates sub-compositions and the A-roll video.
|
|
|
|
### [compositions/bg-grid.html]
|
|
|
|
**Status**: COMPLIANT
|
|
|
|
**Issues Found**:
|
|
|
|
- None. The script uses deterministic loops and fixed arrays for cube placement. The timeline is registered correctly.
|
|
|
|
### [compositions/mg-overlays.html]
|
|
|
|
**Status**: COMPLIANT
|
|
|
|
**Issues Found**:
|
|
|
|
- None. The script uses a finite loop for the background grid pulse instead of an infinite repeat, ensuring a finite timeline.
|
|
|
|
### [compositions/captions.html]
|
|
|
|
**Status**: COMPLIANT
|
|
|
|
**Issues Found**:
|
|
|
|
- None. Captions are grouped and animated deterministically based on the transcript.
|