ext/openworker
2
0
Fork 0
mirror of https://github.com/andrewyng/openworker.git synced 2026-09-11 06:30:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Blur-save non-secret provider fields on configured providers

Browse Source 
The Test button was the form's only save path — extras like the thinking budget
silently never persisted. Blur saves with a Saved flash; empty clears.
This commit is contained in:
Rohit C Prasad
2026-07-23 07:43:24 -07:00
committed by Rohit P
parent 3d00187310
commit a9458524e8
4 changed files with 105 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
surfaces/gui/e2e/fixtures.ts
+7 -2
View File
@@ -328,7 +328,7 @@ const PROVIDERS = [
// openai: configured + used (drives the "Last used" sub-line and the status dot).
{ name: "openai", title: "OpenAI", needs_key: true, fields: [{ key: "api_key", label: "OpenAI API key", secret: true, required: true, help: "", placeholder: "sk-…" }], configured: true, values: {}, suggested_models: ["gpt-5.5"], key_set_at: "2026-06-12", last_used_at: Math.floor(Date.now() / 1000) - 7200 },
// anthropic: configured but never used ("Not used yet").
{ name: "anthropic", title: "Claude (Anthropic)", needs_key: true, fields: [{ key: "api_key", label: "API key", secret: true, required: true, help: "", placeholder: "sk-…" }], configured: true, values: {}, suggested_models: ["claude-opus-4-8"], key_set_at: null, last_used_at: null },
{ name: "anthropic", title: "Claude (Anthropic)", needs_key: true, fields: [{ key: "api_key", label: "API key", secret: true, required: true, help: "", placeholder: "sk-…" }, { key: "thinking_budget", label: "Extended thinking budget (tokens, optional)", secret: false, required: false, help: "Turns on Claude's extended thinking for every request.", placeholder: "e.g. 8192 — blank = off" }], configured: true, values: {}, suggested_models: ["claude-opus-4-8"], key_set_at: null, last_used_at: null },
// zai: an OpenAI-compatible vendor — unconfigured, with a prefilled editable endpoint + blurb.
{ name: "zai", title: "Z AI (GLM)", needs_key: true, blurb: "Uses Z AI's OpenAI-compatible API — the endpoint is prefilled, just add your key.", fields: [{ key: "api_key", label: "Z AI API key", secret: true, required: true, help: "", placeholder: "" }, { key: "base_url", label: "Endpoint", secret: false, required: false, help: "Prefilled with Z AI's international endpoint.", placeholder: "https://api.z.ai/api/paas/v4", default: "https://api.z.ai/api/paas/v4" }], configured: false, values: {}, suggested_models: ["glm-5.2"], key_set_at: null, last_used_at: null },
// ollama: keyless local provider — "configured" without proving anything runs; the
@@ -1240,7 +1240,12 @@ export async function mockApi(page: import("@playwright/test").Page) {
prov.configured = true;
prov.key_set_at = "2026-07-05";
}
if (b.fields?.base_url) prov.values = { ...prov.values, base_url: b.fields.base_url };
// Backend parity: non-secret fields merge into `values` (empty clears them).
for (const [k, v] of Object.entries(b.fields || {})) {
if (k === "api_key") continue;
if (v) prov.values = { ...prov.values, [k]: v };
else if (prov.values) delete prov.values[k];
}
return json({ ok: true, provider: b.name, recommended_model: null });
}
// forget a provider's stored config (Settings ▸ Models "Remove key…").
surfaces/gui/e2e/provider-keys.spec.ts
+18
View File
@@ -52,3 +52,21 @@ test("a configured provider's form opens with the saved state, no plaintext key"
await expect(page.getByTestId("set-field-api_key")).toHaveValue("");
await expect(page.getByTestId("set-field-api_key")).toHaveAttribute("placeholder", "••••••••");
});
test("non-secret extras blur-save on a configured provider (thinking budget)", async ({
page,
}) => {
// Owner-hit 2026-07-23: typed a thinking budget, left Settings, value silently never
// saved — the Test button was the form's only save path. Blur now saves extras.
await openModels(page);
await page.getByTestId("set-provider-anthropic").click();
const budget = page.getByTestId("set-field-thinking_budget");
await budget.fill("8192");
await budget.blur();
await expect(page.getByTestId("set-field-saved-thinking_budget")).toBeVisible();
// Leave and come back: the value survived (served from the provider's stored values).
await page.getByTestId("set-back").click();
await page.getByTestId("set-provider-anthropic").click();
await expect(page.getByTestId("set-field-thinking_budget")).toHaveValue("8192");
});