mirror of
https://github.com/andrewyng/openworker.git
synced 2026-09-11 06:30:25 +00:00
Rohit C Prasad
13f9c0b6c0
swe-lead (minimal tools, coordination verbs) + swe/design/test workers with the shared worker contract; workers never surface in the picker — they're staffed, not started. Staffing card rides the approval slot; workers nest under the lead's ONE expandable RECENT entry in both sidebar layouts.
107 lines
4.1 KiB
Python
107 lines
4.1 KiB
Python
"""Phase 1 gate — persona registry lifecycle (installed → enabled → surfaced + default)."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import pytest
|
|
|
|
from coworker.personas.registry import DEFAULT_PERSONA_ID, PersonaRegistry
|
|
|
|
|
|
def _reg(tmp_path) -> PersonaRegistry:
|
|
return PersonaRegistry(state_path=tmp_path / "personas.json")
|
|
|
|
|
|
def test_builtins_present(tmp_path):
|
|
reg = _reg(tmp_path)
|
|
assert {"code", "chat", "cowork", "ops"} <= set(reg.ids())
|
|
assert reg.get("ops").builtin is True
|
|
# Ops came from a markdown manifest; Code from a builder.
|
|
assert reg.get("ops").manifest is not None
|
|
assert reg.get("code").manifest is None
|
|
|
|
|
|
def test_sidebar_defaults_to_surfaced_builtins(tmp_path):
|
|
reg = _reg(tmp_path)
|
|
sidebar = reg.sidebar()
|
|
ids = [e["name"] for e in sidebar]
|
|
# Built-ins ship enabled (UX-029: the coworker picker is their front door); Chat
|
|
# stays default-hidden via the surfaced axis. Installed personas remain opt-in.
|
|
assert ids[0] == "cowork"
|
|
# swe-lead surfaces (the user's entry to a team); team workers never do.
|
|
assert set(ids) == {
|
|
"cowork", "code", "ops", "security", "cloud-posture", "dep-audit", "swe-lead",
|
|
}
|
|
assert not any(i in ids for i in ("swe-worker", "design-worker", "test-worker"))
|
|
assert sidebar[0]["default"] is True
|
|
# An explicit disable removes a builtin from the picker.
|
|
reg.set_enabled("code", False)
|
|
assert "code" not in [e["name"] for e in reg.sidebar()]
|
|
|
|
|
|
def test_chat_retired_by_default_but_resolvable(tmp_path):
|
|
reg = _reg(tmp_path)
|
|
# Chat is retired (owner call 2026-08-11): disabled + unsurfaced out of the box,
|
|
# unlike the other builtins — Coworker covers quick Q&A.
|
|
assert reg.is_enabled("chat") is False
|
|
assert reg.is_surfaced("chat") is False
|
|
assert reg.agent("chat").name == "chat" # live sessions keep resolving
|
|
# Still recoverable from Settings ▸ Coworkers (enable implies surface).
|
|
reg.set_enabled("chat", True)
|
|
assert "chat" in [e["name"] for e in reg.sidebar()]
|
|
|
|
|
|
def test_surface_toggle_filters_picker_but_keeps_resolvable(tmp_path):
|
|
reg = _reg(tmp_path)
|
|
reg.set_surfaced("ops", False)
|
|
assert "ops" not in [e["name"] for e in reg.sidebar()]
|
|
# Still installed + still resolvable (a session already on Ops keeps working).
|
|
assert "ops" in reg.ids()
|
|
assert reg.agent("ops").name == "ops"
|
|
assert any(p["id"] == "ops" and not p["surfaced"] for p in reg.list_all())
|
|
|
|
|
|
def test_disable_default_falls_back(tmp_path):
|
|
reg = _reg(tmp_path)
|
|
assert reg.default_id() == DEFAULT_PERSONA_ID # cowork
|
|
reg.set_enabled("ops", True) # another persona must be enabled to fall back to
|
|
reg.set_enabled("cowork", False)
|
|
# Cowork off → default resolves to another enabled persona, not cowork.
|
|
assert reg.default_id() != "cowork"
|
|
# Unknown / unspecified persona falls back to the (new) default, which is enabled.
|
|
fallback = reg.agent(None)
|
|
assert reg.is_enabled(fallback.name)
|
|
|
|
|
|
def test_set_default_enables_and_persists(tmp_path):
|
|
reg = _reg(tmp_path)
|
|
reg.set_default("ops")
|
|
assert reg.default_id() == "ops" and reg.is_enabled("ops")
|
|
# New instance reads persisted state.
|
|
reg2 = _reg(tmp_path)
|
|
assert reg2.default_id() == "ops"
|
|
|
|
|
|
def test_agent_resolution(tmp_path):
|
|
reg = _reg(tmp_path)
|
|
assert reg.agent("ops").family == "knowledge"
|
|
assert reg.agent("code").family == "code"
|
|
# Unknown id → default persona.
|
|
assert reg.agent("does-not-exist").name == reg.default_id()
|
|
|
|
|
|
def test_list_all_carries_workspace_enum(tmp_path):
|
|
# Post-§16 collapse: workspace derives from family — code → git, knowledge → deliverable
|
|
# (scratch). Only builder-registered Chat keeps "none". Ops is a scratch persona now.
|
|
reg = _reg(tmp_path)
|
|
ws = {p["id"]: p["workspace"] for p in reg.list_all()}
|
|
assert ws["code"] == "git"
|
|
assert ws["cowork"] == "deliverable"
|
|
assert ws["chat"] == "none"
|
|
assert ws["ops"] == "deliverable"
|
|
|
|
|
|
def test_set_unknown_persona_raises(tmp_path):
|
|
reg = _reg(tmp_path)
|
|
with pytest.raises(KeyError):
|
|
reg.set_enabled("ghost", False)
|