test(producer): the injector budget test no longer leaves a no-op injector for later tests (#7384)

This commit is contained in:
Miguel Ángel
2026-11-07 22:54:11 +00:00
committed by GitHub
parent a0bbaab436
commit 34118d8f20
2 changed files with 30 additions and 19 deletions
@@ -1,25 +1,34 @@
import { afterAll, describe, expect, it, mock } from "bun:test";
const real = await import("@hyperframes/engine");
const created: unknown[] = [];
mock.module("@hyperframes/engine", () => ({
...real,
createVideoFrameInjector: (_lookup: unknown, options: unknown) => {
created.push(options);
return async () => {};
},
}));
afterAll(() => mock.module("@hyperframes/engine", () => real));
const { createChunkVideoFrameInjectorFactory } = await import("./chunkFrames.js");
import { describe, expect, it } from "bun:test";
import { createFrameLookupTable } from "@hyperframes/engine";
import {
chunkFrameInjectorDependencies,
createChunkVideoFrameInjectorFactory,
} from "./chunkFrames.js";
const budget = { frameDataUriCacheLimit: 256, frameDataUriCacheBytesLimitMb: 375 };
describe("chunk video frame injector budget", () => {
it("hands the shared cache budget to every injector it builds", async () => {
const lookup = real.createFrameLookupTable([], []);
createChunkVideoFrameInjectorFactory(lookup, budget)();
await createChunkVideoFrameInjectorFactory(Promise.resolve(lookup), budget)()?.({} as never, 0);
const created: unknown[] = [];
const real = chunkFrameInjectorDependencies.createVideoFrameInjector;
chunkFrameInjectorDependencies.createVideoFrameInjector = (_lookup, options) => {
created.push(options);
return async () => {};
};
try {
const lookup = createFrameLookupTable([], []);
createChunkVideoFrameInjectorFactory(lookup, budget)();
await createChunkVideoFrameInjectorFactory(Promise.resolve(lookup), budget)()?.(
{} as never,
0,
);
} finally {
chunkFrameInjectorDependencies.createVideoFrameInjector = real;
}
expect(created).toEqual([budget, budget]);
});
it("leaves the engine's own injector in place for every later test", () => {
expect(createChunkVideoFrameInjectorFactory(null)()).toBeNull();
});
});
@@ -49,17 +49,19 @@ export class RenderChunkValidationError extends Error {
}
}
export const chunkFrameInjectorDependencies = { createVideoFrameInjector };
/** One injector per browser session: a hook reused on a fresh page can skip its first injection. */
export function createChunkVideoFrameInjectorFactory(
frameLookup: FrameLookupTable | Promise<FrameLookupTable> | null,
options?: Parameters<typeof createVideoFrameInjector>[1],
): () => BeforeCaptureHook | null {
if (!(frameLookup instanceof Promise))
return () => createVideoFrameInjector(frameLookup, options);
return () => chunkFrameInjectorDependencies.createVideoFrameInjector(frameLookup, options);
return () => {
let hook: BeforeCaptureHook | null | undefined;
return async (page, time, heldVideoTime) => {
hook ??= createVideoFrameInjector(await frameLookup, options);
hook ??= chunkFrameInjectorDependencies.createVideoFrameInjector(await frameLookup, options);
await hook?.(page, time, heldVideoTime);
};
};